This is a list of deprecations introduced in 1.x cycle:

Create URL argument

ID: ember-cli-page-object.create-url-argument

Until: 2.0.0

In order to align create( and collection(, we now deprecate accepting an URL as the first argument of create(.

In order to migrate, use visitable attribute please:

Bad:

import { create } from 'ember-cli-page-object';

const page = create('/some-url', {
  scope: '.selector',
});

Good:

import { create, visitable } from 'ember-cli-page-object';

const page = create({
  scope: 'input',

  visit: visitable('/some-url')
});

String properties on definition

ID: ember-cli-page-object.string-properties-on-definition

Until: 2.0.0

In v2, any string values in definitions, other than scope and testContainer, would be treated as a scope selectors.

Please make sure there are no plain strings used in your definitions.

Bad:

import { create } from 'ember-cli-page-object';

const page = create({
  scope: 'input',

  propertyName: 'I will become a nested component scope'
});

If you really need your definition to keep a string, use getter instead:

Good:

import { create } from 'ember-cli-page-object';

const page = create({
  scope: 'input',

  get propertyName() {
    return 'I will not become a scope :(';
  }
});

Multiple

ID: ember-cli-page-object.multiple

Until: 2.0.0

multiple option makes our internals significantly more complex, and extends API surface for each attribute without big benefits.

It can also confuse a consumer of page object which uses multiple, because when accessing an attribute one may expect to get a scalar value, rather than array.

In order to migrate use collections please:

Bad:

import { create, is } from 'ember-cli-page-object';

const page = create({
  scope: 'div',

  tags: text('.tag', { multiple: true }),
});

// usage
assert.deepEqual(page.tags, ['one', 'two', 'three'])

Good:

import { create, collection } from 'ember-cli-page-object';

const page = create({
  scope: 'div',

  tags: collection('.tag'),
});

// usage
assert.deepEqual(page.tags.map((t) => t.text), ['one', 'two', 'three'])

or, if you want to leave your tests unchanged:

import { create, collection } from 'ember-cli-page-object';

const page = create({
  scope: 'div',

  _tags: collection('.tag'),

  get tags() {
    return this._tags.map((t) => t.text);
  }
});

// usage
assert.deepEqual(page.tags, ['one', 'two', 'three'])

Is property

ID: ember-cli-page-object.is-property

Until: 2.0.0

In scope of gradual reducing of jQuery APIs exposed directly to the user, we no longer recommend to use is property, and plan to remove it in v2 of page objects.

The most common use cases for is( are covered with a property helper. Please use it instead.

Bad:

import { create, is } from 'ember-cli-page-object';

const page = create({
  scope: 'input',

  isChecked: is(':checked'),

  isDisabled: is(':disabled')
});

Good:

import { create, property } from 'ember-cli-page-object';

const page = create({
  scope: 'input',

  isChecked: property('checked'),

  isDisabled: property('disabled')
})

In case there is no built-in replacement for is in ember-cli-page-object, you can write your custom getter property, to achieve behavior you need.

Set context

ID: ember-cli-page-object.set-context

Until: 2.0.0

With “@ember@test-helpers@1.0.0” or higher you don’t need to set page object context anymore, it would be handled for you:

Bad:

  page.setContext(this);
  page.removeContext(this);

  const page = create({
    context: this
  });

Good: Make sure you are using the most recent version of “@ember/test-helpers” and remove setting of context from your test suite.

Comma-separated Selectors

ID: ember-cli-page-object.comma-separated-selectors

Until: 2.0.0

Comma separated selectors are not supported in ember-cli-page-object.

Bad:

<h1>A big title</h1>
<h2>A smaller title</h2>
import { create, text } from "ember-cli-page-object";

var page = create({
  title: text("h1, h2")
});

Good:

<h1 data-test-title>A big title</h1>
<h2 data-test-title>A smaller title</h2>
import { create, text } from "ember-cli-page-object";

var page = create({
  title: text("[data-test-title]")
})

Import from test-support

ID: ember-cli-page-object.import-from-test-support

Until: 2.0.0

Importing page object helpers from tests/ folder is deprecated. Please import from ember-cli-page-object instead.

Bad:

import { create, text } from "my-app/tests/page-object";

var page = create({
  title: text("h1")
});

Good:

import { create, text } from "ember-cli-page-object";

var page = create({
  title: text("h1")
});

Old collection API

ID: ember-cli-page-object.old-collection-api

Until: 2.0.0

Usage of item and itemScope are now deprecated. Use the new simplified collections API instead:

<table>
  <caption>List of users</caption>
  <tbody>
    <tr>
      <td>Mary<td>
      <td>Watson</td>
    </tr>
    <tr>
      <td>John<td>
      <td>Doe</td>
    </tr>
  </tbody>
</table>

Bad:

const page = create({

  users: collection({
    itemScope: 'table tr',

    item: {
      firstName: text('td', { at: 0 }),
      lastName: text('td', { at: 1 })
    },

    caption: text('caption')
  });
});

// test
assert.equal(page.users().count, 2);
assert.equal(page.users(1).firstName, 'John');

Good:

const page = create({
  users: collection('table tr', {
    firstName: text('td', { at: 0 }),
    lastName: text('td', { at: 1 })
  }),

  usersCaption: text('caption')
});

assert.equal(page.users.length, 2);
assert.equal(page.users.objectAt(1).firstName, 'John');

Page Render

ID: ember-cli-page-object.page-render

Until: 2.0.0

Using page.render('') to render a component is deprecated. Please use render directly from your test framework instead:

import { moduleForComponent, test } from 'ember-qunit';

import hbs from 'htmlbars-inline-precompile';
import { create } from 'ember-cli-page-object';

moduleForComponent('calculating-device', 'Deprecation | page.render()', {
  integration: true,

  beforeEach() {
    this.page = create({context: this});
  }
});

test('renders component', function(assert) {
  // BAD
  this.page.render(hbs``);
  
  // GOOD
  this.render(hbs``);
});

Old finders

ID: ember-cli-page-object.old-finders

Until: 2.0.0

Using findElement and findElementWithAssert is deprecated. Please use findOne or findMany instead.

import { findOne, findMany } from 'ember-cli-page-object/extend';

export default function isDisabled(selector, options = {}) {
  return {
    isDescriptor: true,

    get() {
      return findOne(this, selector, options).disabled;
    }
  };
}

export default function count(selector, options = {}) {
  return {
    isDescriptor: true,

    get() {
      return findMany(this, selector, options).length;
    }
  };
}